1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
(** GPX validation utilities *)
(** Validation error messages *)
type validation_issue = {
level : [`Error | `Warning];
message : string;
location : string option;
}
type validation_result = {
issues : validation_issue list;
is_valid : bool;
}
let make_error ?location message = {
level = `Error;
message;
location;
}
let make_warning ?location message = {
level = `Warning;
message;
location;
}
(** Validate waypoint data *)
let validate_waypoint_data wpt location =
let issues = ref [] in
(match Waypoint.sat wpt with
| Some sat when sat < 0 ->
issues := make_warning ~location ("Negative satellite count: " ^ string_of_int sat) :: !issues
| _ -> ());
let check_precision name value =
match value with
| Some v when v < 0.0 ->
issues := make_warning ~location (Printf.sprintf "Negative %s value: %.2f" name v) :: !issues
| Some v when v > 1000.0 ->
issues := make_warning ~location (Printf.sprintf "Very large %s value: %.2f" name v) :: !issues
| _ -> ()
in
check_precision "hdop" (Waypoint.hdop wpt);
check_precision "vdop" (Waypoint.vdop wpt);
check_precision "pdop" (Waypoint.pdop wpt);
(match Waypoint.elevation wpt with
| Some ele when ele < -15000.0 ->
issues := make_warning ~location (Printf.sprintf "Very low elevation: %.2f m" ele) :: !issues
| Some ele when ele > 15000.0 ->
issues := make_warning ~location (Printf.sprintf "Very high elevation: %.2f m" ele) :: !issues
| _ -> ());
(match Waypoint.ageofdgpsdata wpt with
| Some age when age < 0.0 ->
issues := make_error ~location "Negative DGPS age" :: !issues
| _ -> ());
!issues
(** Validate bounds *)
let validate_bounds bounds =
let issues = ref [] in
let location = "bounds" in
let (minlat, minlon, maxlat, maxlon) = Metadata.Bounds.bounds bounds in
if Coordinate.latitude_to_float minlat >= Coordinate.latitude_to_float maxlat then
issues := make_error ~location "minlat must be less than maxlat" :: !issues;
if Coordinate.longitude_to_float minlon >= Coordinate.longitude_to_float maxlon then
issues := make_error ~location "minlon must be less than maxlon" :: !issues;
!issues
(** Validate metadata *)
let validate_metadata metadata =
let issues = ref [] in
(match Metadata.bounds_opt metadata with
| Some bounds -> issues := validate_bounds bounds @ !issues
| None -> ());
(match Metadata.copyright metadata with
| Some copyright ->
(match Link.copyright_year copyright with
| Some year when year < 1900 || year > 2100 ->
issues := make_warning ~location:"metadata.copyright"
(Printf.sprintf "Unusual copyright year: %d" year) :: !issues
| _ -> ())
| None -> ());
!issues
(** Validate route *)
let validate_route route =
let issues = ref [] in
let location = "route" in
let points = Route.points route in
if points = [] then
issues := make_warning ~location "Route has no points" :: !issues;
List.iteri (fun i rtept ->
let point_location = Printf.sprintf "route.rtept[%d]" i in
issues := validate_waypoint_data rtept point_location @ !issues
) points;
!issues
(** Validate track segment *)
let validate_track_segment trkseg seg_idx =
let issues = ref [] in
let location = Printf.sprintf "track.trkseg[%d]" seg_idx in
let points = Track.Segment.points trkseg in
if points = [] then
issues := make_warning ~location "Track segment has no points" :: !issues;
List.iteri (fun i trkpt ->
let point_location = Printf.sprintf "%s.trkpt[%d]" location i in
issues := validate_waypoint_data trkpt point_location @ !issues
) points;
let rec check_time_order prev_time = function
| [] -> ()
| trkpt :: rest ->
(match (prev_time, Waypoint.time trkpt) with
| (Some prev, Some curr) when Ptime.compare prev curr > 0 ->
issues := make_warning ~location "Track points not in chronological order" :: !issues
| _ -> ());
check_time_order (Waypoint.time trkpt) rest
in
check_time_order None points;
!issues
(** Validate track *)
let validate_track track =
let issues = ref [] in
let location = "track" in
let segments = Track.segments track in
if segments = [] then
issues := make_warning ~location "Track has no segments" :: !issues;
List.iteri (fun i trkseg ->
issues := validate_track_segment trkseg i @ !issues
) segments;
!issues
(** Validate complete GPX document *)
let validate_gpx gpx =
let issues = ref [] in
let version = Doc.version gpx in
if version <> "1.0" && version <> "1.1" then
issues := make_error ~location:"gpx"
(Printf.sprintf "Unsupported GPX version: %s (supported: 1.0, 1.1)" version) :: !issues
else if version = "1.0" then
issues := make_warning ~location:"gpx"
"GPX 1.0 detected - consider upgrading to GPX 1.1 for better compatibility" :: !issues;
let creator = Doc.creator gpx in
if String.trim creator = "" then
issues := make_error ~location:"gpx" "Creator cannot be empty" :: !issues;
(match Doc.metadata gpx with
| Some metadata -> issues := validate_metadata metadata @ !issues
| None -> ());
let waypoints = Doc.waypoints gpx in
List.iteri (fun i wpt ->
let location = Printf.sprintf "waypoint[%d]" i in
issues := validate_waypoint_data wpt location @ !issues
) waypoints;
let routes = Doc.routes gpx in
List.iteri (fun _i route ->
issues := validate_route route @ !issues
) routes;
let tracks = Doc.tracks gpx in
List.iteri (fun _i track ->
issues := validate_track track @ !issues
) tracks;
if waypoints = [] && routes = [] && tracks = [] then
issues := make_warning ~location:"gpx" "GPX document contains no geographic data" :: !issues;
let all_issues = !issues in
let has_errors = List.exists (fun issue -> issue.level = `Error) all_issues in
{ issues = all_issues; is_valid = not has_errors }
(** Quick validation - returns true if document is valid *)
let is_valid gpx =
let result = validate_gpx gpx in
result.is_valid
(** Get only error messages *)
let errors gpx =
let result = validate_gpx gpx in
List.filter (fun issue -> issue.level = `Error) result.issues
(** Get only warning messages *)
let warnings gpx =
let result = validate_gpx gpx in
List.filter (fun issue -> issue.level = `Warning) result.issues
(** Format validation issue for display *)
let format_issue issue =
let level_str = match issue.level with
| `Error -> "ERROR"
| `Warning -> "WARNING"
in
let location_str = match issue.location with
| Some loc -> " at " ^ loc
| None -> ""
in
Printf.sprintf "%s%s: %s" level_str location_str issue.message